Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggbio rmd #168

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

ggbio rmd #168

wants to merge 10 commits into from

Conversation

Rohit-Satyam
Copy link

Requesting @jwokaty to review and suggest changes in the .Rmd file, if required.

@jwokaty
Copy link
Contributor

jwokaty commented Jan 11, 2023

@Rohit-Satyam I am still reviewing your work; however, I tried to R CMD build the package as it would on the build system, but it's only finding the .Rnw:

R CMD build ggbio
* checking for file ‘ggbio/DESCRIPTION’ ... OK
* preparing ‘ggbio’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
--- re-building ‘ggbio.Rnw’ using Sweave
--- finished re-building ‘ggbio.Rnw’

cp realvignettes/*.Rnw .
cp: cannot stat 'realvignettes/*.Rnw': No such file or directory
make: *** [Makefile:14: ggbio.pdf] Error 1
Error in tools::buildVignettes(dir = ".", tangle = TRUE) : 
  running 'make' failed
Execution halted

I know I can rmarkdown::render() the html, so that isn't the issue and it's likely because of the path.

Since the .Rmd is replacing the need for the other files--fakevignettes, realvignettes, Makefile, knit.sh, and ggbio.Rnw--they can be removed and what you put in realvignettes should be moved to the /vignettes directory. I think you should still the original figures and their names in your .Rmd file.

@Rohit-Satyam
Copy link
Author

Rohit-Satyam commented Apr 29, 2023

@Rohit-Satyam I am still reviewing your work; however, I tried to R CMD build the package as it would on the build system, but it's only finding the .Rnw:

R CMD build ggbio
* checking for file ‘ggbio/DESCRIPTION’ ... OK
* preparing ‘ggbio’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
--- re-building ‘ggbio.Rnw’ using Sweave
--- finished re-building ‘ggbio.Rnw’

cp realvignettes/*.Rnw .
cp: cannot stat 'realvignettes/*.Rnw': No such file or directory
make: *** [Makefile:14: ggbio.pdf] Error 1
Error in tools::buildVignettes(dir = ".", tangle = TRUE) : 
  running 'make' failed
Execution halted

I know I can rmarkdown::render() the html, so that isn't the issue and it's likely because of the path.

Since the .Rmd is replacing the need for the other files--fakevignettes, realvignettes, Makefile, knit.sh, and ggbio.Rnw--they can be removed and what you put in realvignettes should be moved to the /vignettes directory. I think you should still the original figures and their names in your .Rmd file.

I have removed the aforementioned files and folders. The vignette HTML file is also attached:

ggbio.zip

Added missing `\` in the vignette section of YAML header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants